search

barrel-db / rebar3_elixir_compile

Elixir rebar3 compiler plugin
Other
90 stars 29 forks source link

Use hex_repo.erl to download package tarball #36

Closed kubaodias closed 3 years ago

kubaodias commented 6 years ago

It would be good to use official hex.pm client to download package tarball.

benoitc commented 6 years ago

👍 My only concern is the usage of a git url. Do you know if it would be possible to have the client available on hex ? Without it I think it will prevent us to ship the plugin via hex.pm.

kubaodias commented 6 years ago

@wojtekmach What do you think?

wojtekmach commented 6 years ago

we're pretty close to the first public release of hex_erl but there's still work to do, we don't have an ETA when it's gonna be finished but I'd say within next couple of months.

hex_erl was designed to be embeddable into build tools so if you'd rather not add it as git dependency, consider vendoring it? WDYT @ericmj? Here's a vendor.sh script that we use, e.g. for Hex we run it with the mix_ prefix.

wojtekmach commented 6 years ago

I've talked with Eric, it's best if you wait for a public release, we'll try to get that out soon!

kubaodias commented 5 years ago

@benoitc, @wojtekmach Please review if usage of config for hex_repo.erl API is OK.

benoitc commented 3 years ago

i will look. thanks!

On Tue 20 Apr 2021 at 12:12, Wojtek Mach @.***> wrote:

@.**** commented on this pull request.

In rebar.lock https://github.com/barrel-db/rebar3_elixir_compile/pull/36#discussion_r616544494 :

@@ -0,0 +1,6 @@ +{"1.1.0", +[{<<"hex_core">>,{pkg,<<"hex_core">>,<<"0.2.1">>},0}]}.

fyi the latest version is 0.7.1 now, consider upgrading just in case. We may have introduced minor incompatibilities in the meantime, sorry about that!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/barrel-db/rebar3_elixir_compile/pull/36#pullrequestreview-639765697, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADRIST3HOHVP7DWA6B5V3TJVHQLANCNFSM4FIVPL4A .

-- Sent from my Mobile