search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

Issue with Application #10

Closed JeremyHutchings closed 8 years ago

JeremyHutchings commented 8 years ago

Hello there,

I was just experimenting with the parser and some local replays I have, and ended up getting an error. Was wondering if you could give me any insight into it please ?

Thanks Jeremy

parser issue

console

barrett777 commented 8 years ago

Are you using the current version of the parser? This error can happen if you are parsing a new replay file with an older version of the replay parser.

If not, could you email me the replay file to admin@hotslogs.com?

On Tue, Dec 1, 2015 at 9:42 AM, Jeremy Hutchings notifications@github.com wrote:

Hello there,

I was just experimenting with the parser and some local replays I have, and ended up getting an error. Was wondering if you could give me any insight into it please ?

Thanks Jeremy

[image: parser issue] https://cloud.githubusercontent.com/assets/439559/11508876/d5212186-980f-11e5-854e-25515c57f5c9.png

[image: console] https://cloud.githubusercontent.com/assets/439559/11508881/dadd0c34-980f-11e5-9bb4-5ba85966e705.png

— Reply to this email directly or view it on GitHub https://github.com/barrett777/Heroes.ReplayParser/issues/10.

JeremyHutchings commented 8 years ago

Thanks, will do. It's the latest code out of GH.

barrett777 commented 8 years ago

I was able to parse the 3 replays you sent me; are you sure you are using my current master branch?

At the top of that file you should find this line if it is the current version:

// Referenced from https://raw.githubusercontent.com/Blizzard/s2protocol/master/protocol38215.py (Void Beta)

barrett777 commented 8 years ago

Well I'm going to close this, let me know if it is still a problem

JeremyHutchings commented 8 years ago

Yes, we still have issues now it's an index out of range.

index_out_of_range

I grabbed a replay from : http://eu.ets.gg/replays

Team Liquid HotS Fnatic HotS Enter The Storm EU 4 (EU Qualifier # 3) 5. Dec 2015

barrett777 commented 8 years ago

There were 3 replays with the title you linked, but I was able to parse them all successfully

Are you using the sample console application I supplied? You do need to parse the contained files in a specific order, which the console application follows.

If you are not using the console application, and just parsing ReplayGameEvents, the 'replay.ClientList' list will be empty as player data comes from a different file.

If you are using the sample console application, I really think you might be using an older version

Unfortunately the exception in your screenshot covers up a version number. In your screenshot, can you check the comment that starts with:

"// Referenced from https://raw.github....."

If it's the current version it should be: "Referenced from https://raw.githubusercontent.com/Blizzard/s2protocol/master/protocol38215.py (Void Beta)"

JeremyHutchings commented 8 years ago

Hi, back to it.

On the latest code for the application seems there is a lib / build error ?

Would it be possible to commit a working exe to the repo?

build_error

JeremyHutchings commented 8 years ago

btw I'm sure it's 38215 now

38215

barrett777 commented 8 years ago

Oh SharpZipLib is a NuGet package for the 'MpqTool' project. If you right click the solution, you can 'Restore NuGet Packages' to restore it

If it still doesn't find the reference, you can use the NuGet Package Manager to uninstall and reinstall SharpZipLib, just for the 'MpqTool' project

JeremyHutchings commented 8 years ago

Looks like we're getting there.

replat data

Is there an easy way to get the end KDA in the console app ?

barrett777 commented 8 years ago

Glad you got it working :)

Unfortunately KDA is not yet available in the replay file (or I haven't found it)

Each player object does have a list of deaths, which I believe is accurate for all normal heroes. It doesn't work for Lost Vikings or Uther's lv 20 resurrection talent for example

If you debug the application, you can see everything available in the 'Replay' object, and the associated Player and Unit lists

JeremyHutchings commented 8 years ago

:)

http://us.battle.net/heroes/en/blog/19991410

barrett777 commented 8 years ago

Yeah :) I'm excited! I'll update my Github shortly after they add this

JeremyHutchings commented 8 years ago

I'm excited!

Me too ! Really looking forward to it. Any chance you could add the KDA data to the test app when you do please ?

ghost commented 7 years ago

I'm getting the same library/build error. @JeremyHutchings Restoring NuGet packages doesn't resolve it. Could you explain how you got it resolved?

Edit: never mind. trying it a second time seems to have solved it. strange behavior.