barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

Scaling issue on smaller monitor #11

Closed IAmScience closed 8 years ago

IAmScience commented 8 years ago

Hey again,

Wasn't sure how best to report this as it is related to the actual website, not the parser.

Just refreshed the page and noticed the site now displays weird on my smaller monitor (17", 1280 x 1024 Res). Image attached - Notice everything is being pushed to the left side.

Tested in Chrome, Firefox, and IE, all have the same problem. Happens on all pages. Displays normally on my other monitor at any size.

No errors in console.

Did you update the CSS?

hotslogs scaling

barrett777 commented 8 years ago

Yeah I did update the CSS. It's most noticeable to you because you have ad block on :)

I removed the advertisement on the left, because I changed the one on the right to support advertisements up to 300px in width (up from 160px).

For screen widths over ~1500px, I increased the content width by about 200px.

For screen widths less than 1500px, the content width is the same, but the content is on the left, with the vertical ad on the right

IAmScience commented 8 years ago

I dunno man, even with ad block disabled something looks a little funky.

Like the entire display (including adds) should be centered even at < 1500 px, otherwise there is so much white on the right side.

Just for comparison here is what it looks like currently, with a width of 1280 px: hotslogs scaling

But then if the window is scaled with a width from 769 - 991 px it looks like this, totally cutting off the right-hand side ad: image

Then again at 992 px the content pane expands to fill, then remains the same up to width of 1049 px: image

Not until a window width of 1820 am I seeing it centered, which is the original view.

It just leaves the actual content pane a little small.

Just my 2-cents.

barrett777 commented 8 years ago

Yeah I'll tweak it some more tonight to improve it some. HOTS Logs does rely on ad revenue, so unfortunately I can't justify having empty space on the left, and then cutting off the advertisement on the right. Most users are 1920x1080 anyway thankfully, but I'll try to find some better options for mid sized browsers.