search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

Replays from 11/16/2021 throwing "NotImeplementedException" #122

Closed Zemill closed 2 years ago

Zemill commented 2 years ago

Error getting thrown at

https://github.com/barrett777/Heroes.ReplayParser/blob/99ef9947622ca9f281ac92ea66fd530289e3288a/Heroes.ReplayParser/MPQFiles/ReplayTrackerEvents.cs#L180

replays.zip

barrett777 commented 2 years ago

Hmm... Blizzard hasn't made any changes for a couple months (https://github.com/Blizzard/heroprotocol)

I'll look into it sometime in the next couple days

Zemill commented 2 years ago

Sorry, didn't mean to imply this was new. I've been getting sporadic reports about incomplete replays and finally found a set I was able to replicate it on

barrett777 commented 2 years ago

Ok thanks. I just meant usually the 'Not Implemented' cases happen when Blizzard makes changes. I'm surprised it's coming up now. I'll see what I can find.

koliva8245 commented 2 years ago

It seems that you can't even load/watch the replays. After looking at the binary contents of the files, the mpq header is not in the correct format. Interesting...

barrett777 commented 2 years ago

I can't find an easy way to salvage these replays. Considering you can't open the replays in the game client, I'm assuming something went wrong on Blizzard's end when creating these. I'm giving up for now unless these become more frequent

Zemill commented 2 years ago

Alright I appreciate you spending some time to look into it. Odd it happened to so many of the same users replays, but maybe he has something going on

barrett777 commented 2 years ago

In the past there have been specific issues that affect replays from the Mac version of HotS

Also some goobers try to modify their replay files once in awhile as well

koliva8245 commented 2 years ago

I fixed this replay by rebuilding the mpq header and I see nothing "bad" about replay. No idea why the mpq archive header was built incorrectly.

2021-11-16 19.21.14 Braxis Holdout-fixed.zip