search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

New data added in the usable skins/hero section #40

Closed koliva8245 closed 7 years ago

koliva8245 commented 7 years ago

Do not accept this pull request yet. I need to confirm some results after the patch goes live

PTR build 47801 changed the data in the usable skins section (the section after all the heroes/skins with all the 0x00 and 0x01).
There is no longer any 0x01 but different values if the hero/skin is usable. I've seen 0xC3, 0xC1, 0x02, 0x83. 0xC3 seems to indicate its Free to Play. I'm not sure what the other values mean. If you have time, it'll be helpful to find out what the other values mean. It will probably help to wait until PTR goes live, since almost every hero is Free to Play, thus most values are 0xC3.

New data was added in the battletag section as well. However, the added data was changed in PTR patch build 47944. I've figured out that the added data (in 47944) is just a repeat of the usable skins section's data, although its in a different data format.

barrett777 commented 7 years ago

Sure I'll look into it. My first uneducated guess would be related to Brawls

On Fri, Nov 11, 2016, 3:33 PM koliva8245 notifications@github.com wrote:

Do not accept this pull request yet. I need to confirm some results after the patch goes live

PTR build 47801 changed the data in the usable skins section (the section after all the heroes/skins with all the 0x00 and 0x01). There is no longer any 0x01 but different values if the hero/skin is usable. I've seen 0xC3, 0xC1, 0x02, 0x83. 0xC3 seems to indicate its Free to Play. I'm not sure what the other values mean. If you have time, it'll be helpful to find out what the other values mean. It will probably help to wait until PTR goes live, since almost every hero is Free to Play, thus most values are 0xC3.

New data was added in the battletag section as well. However, the added data was changed in PTR patch build 47944. I've figured out that the added data (in 47944) is just a repeat of the

usable skins section's data, although its in a different data format.

You can view, comment on, or merge this pull request online at:

https://github.com/barrett777/Heroes.ReplayParser/pull/40 Commit Summary

  • New data was added in the battletag section

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/barrett777/Heroes.ReplayParser/pull/40, or mute the thread https://github.com/notifications/unsubscribe-auth/AIDkE4zin2VLPM9TWvZJWh6pT-fKF5V7ks5q9PtjgaJpZM4KwPYL .

koliva8245 commented 7 years ago

I forgot to mention that the 0xC1 value is most likely the standard "this player owns this hero" and 0xC3 seems to take precedence over 0xC1. This makes the values 0x02 and 0x83 really interesting as some players have these values instead of 0xC1. I, unfortunately, don't have any 0x02 or 0x83 values for my heroes/skins.

barrett777 commented 7 years ago

I'll wait until it goes live as well before digging into it. A couple other pieces this might be:

Blizzard unlocks all heroes in accounts given to tournament players, and these accounts do play on the ladder sometimes. This was somewhat common a couple weeks ago around Blizzcon. These accounts had a handful of games played, but showed as Hero Level 20 for whatever Hero they played

Some 'internet cafes' have all heroes unlocked as well. I thought this was just a thing in Korea, but maybe not since here's an english screenshot ( http://i.imgur.com/mmDtERI.png)

On Fri, Nov 11, 2016 at 4:03 PM, koliva8245 notifications@github.com wrote:

I forgot to mention that the 0xC1 value is most likely the standard "this player owns this hero" and 0xC3 seems to take precedence over 0xC1. This makes the values 0x02 and 0x83 really interesting as some players have these values instead of 0xC1. I, unfortunately, don't have any 0x02 or 0x83 values for my heroes/skins.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/barrett777/Heroes.ReplayParser/pull/40#issuecomment-260083860, or mute the thread https://github.com/notifications/unsubscribe-auth/AIDkE7p_HX3TXBHOS0LdkoX779iKvl2Oks5q9QJFgaJpZM4KwPYL .

koliva8245 commented 7 years ago

Go ahead and accept the pull request.

0xC1 is the normal 'owning this skin/hero' and 0xC3 is Free to Play. Any other value indicates the hero was most likely given for free. Interestingly, sometimes the value before 0xC3 has a value, which usually is 0x00.