Update project to .Net Standard 2.0 and .Net Core 2.0

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)

MIT License

223 stars 95 forks source link

Update project to .Net Standard 2.0 and .Net Core 2.0 #56

Closed koliva8245 closed 7 years ago

koliva8245 commented 7 years ago

Libraries these days need to be .Net Standard and this one is no different.

Changes

Heroes.ReplayParser is .Net Standard 2.0 and the console project is .Net Core 2.0
SharpZibLib has been updated to v1.0.0-alpha-2
The project solution has been changed
- The solution is now in the parent folder (like it should be)
Added a default parameter, detailedBattleLobbyParsing for DataParser.ParseReplay()
Some code clean up (which apparently has caused a code conflict)

barrett777 commented 7 years ago

Thanks for putting this together :)

barrett777 commented 7 years ago

I ended up reverting this, sorry :( It's not worth causing trouble for people who aren't interested in it. You'll just have to keep your own branch of it

koliva8245 commented 7 years ago

:( Not that much trouble, just need to add one line for .net framework apps.

https://www.hanselman.com/blog/ReferencingNETStandardAssembliesFromBothNETCoreAndNETFramework.aspx