search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

Unexpected Result on Replay #57

Closed koliva8245 closed 7 years ago

koliva8245 commented 7 years ago

Issue for replay here and its due to this.

Instead of just a return and causing the replay be Unexpected Result, can't we just do

replay.ClientListByWorkingSetSlotID[i] = replay.Players[i];
barrett777 commented 7 years ago

That's not always the case unfortunately. I'd rather the parse fail here than assign the wrong stats to the wrong player.