search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

.NET Core 1.0 support #61

Closed maddyblue closed 6 years ago

maddyblue commented 6 years ago

Is it possible to do something to get .NET Core 1.0 support? I tried some stuff but SharpZipLib doesn't seem to want to work with it. But I'm not a dotnet person, so I'm mostly just confused by all of this and may have missed something obvious.

I'd like this because I want to run this project on AWS Lambda, which doesn't support 2.0 yet.

koliva8245 commented 6 years ago

Open the .netCore.sln solution in visual studio and retarget all three of the project frameworks ConsoleApplication - 2.0 to 1.0 Net Core ReplayParser - 2.0 to 1.6 Net Standard MpqTool - 2.0 to 1.6 Net Standard

Then build the solution. However, I think that the MpqTool project (or ReplayParser) won't build under 1.6 (I can't remember right now) and requires 2.0 to be the minimum. If that's the case you'll try to modify the code to get it to work.

On Thu, Nov 16, 2017 at 1:45 AM, Matt Jibson notifications@github.com wrote:

Is it possible to do something to get .NET Core 1.0 support? I tried some stuff but SharpZipLib doesn't seem to want to work with it. But I'm not a dotnet person, so I'm mostly just confused by all of this and may have missed something obvious.

I'd like this because I want to run this project on AWS Lambda, which doesn't support 2.0 yet.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/barrett777/Heroes.ReplayParser/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AIko6mpvguD6zDul-BvfzvmvhPTwGSezks5s2-gggaJpZM4QgFMj .

barrett777 commented 6 years ago

Thanks for the info @koliva8245, I appreciate it!

maddyblue commented 6 years ago

Nope, this doesn't appear to work. It complains about various things not existing and the SharpZipLib error is the same also. I guess this isn't possible.

poma commented 6 years ago

This commit in my fork adds support for different compression libraries, maybe some of them will work with .NET Core 1.0

https://github.com/poma/Heroes.ReplayParser/commit/ea7cb54870e9ba7f83f535a5b30785b4ece2ad44

rogusdev commented 6 years ago

If you go looking at the various libraries on nuget and their websites' changelogs, you can almost certainly find a version to use that will be 1.0 compatible. They all ran on 1.0 not that long ago, unless they are brand new libraries.

koliva8245 commented 6 years ago

Here's your compatible .Net Core 1.0 (and .Net Standard 1.6) solution https://github.com/koliva8245/Heroes.ReplayParser/tree/core-1.0

The SharpZibLib that's being used is v1.0.0-alpha2 which is compatible with .Net Standard 1.6

maddyblue commented 6 years ago

Woo thanks. This helps a lot.