search

barrett777 / Heroes.ReplayParser

A C# library for parsing Heroes of the Storm replay files (.StormReplay)
MIT License
223 stars 95 forks source link

1.2.3 is breaking the API #99

Closed martijnhoekstra closed 3 years ago

martijnhoekstra commented 4 years ago

v 1.2.3. is API breaking vs 1.2.2. The package seems to be packaged with semver (at least, according to the used plugins), which means the package major version should have changed to 2.0.0 per https://semver.org/

barrett777 commented 4 years ago

Yes you are right, I'll make a 2.0.0 after development slows down. I think there are more pieces that need to be merged at this time.

barrett777 commented 3 years ago

I'm just going to close this now. I goofed with the version number choice, but it's old news now. Sorry!

MGatner commented 3 years ago

I forgive you!