Closed chrjorgensen closed 3 months ago
There is an issue with the CMD label specified instead of type:
Ideas to fix this are welcome... 😉 ...else it will have to stay like that until some bright person comes along... 😄
Ah yeah I see, CCSIDs are a nightmare. I always wondered how that part of the editor figured out CCSID. When I tried to make a prototype before Code for IBM i came out that problem (amongst others) made me scrap it.
For this PR, does this fix all CCSID identifier issues or just the ones that are currently known?
@barrettotte Check my comment here - I made the change for all CCSID's with different characters. There is a link in the comment to a CCSID table I created and used as a basis for this change.
My change is connected to your commit above - if these special characters are to be included in RPGLE identifiers, so should all variants and also for CLLE and CMD sources types.
I didn't go through all source types, e.g. any DDS or PNLGRP - I only changed the CL and CMD types. To be complete, all source types should have the same rules for identifiers (according to the language specs), but this was a quick fix.
@chrjorgensen merged. Thanks again for adding this, CCSIDs make my head spin lol.
I'll add a new release by end of day. ~I'm only going to add one more thing to the release. I want to add the bundled .vsix
to the release files via the Github action.~
edit: Actually that will be the only change in the release. Adding the bundled .vsix
is redundant since its already available for download on vs code marketplace and open vsx
This PR will
add variants of $, @ and # in other CCSID's to the RPGLE identifier regexes
add $, @ and # and variants in other CCSID's to the CLLE identifier regexes
add $, @ and # and variants in other CCSID's to the CMD identifier regexes