search

barrettotte / vscode-ibmi-languages

Syntax highlighting for IBM i languages such as RPG, CL, DDS, MI, and RPGLE fixed/free.
https://marketplace.visualstudio.com/items?itemName=barrettotte.ibmi-languages
MIT License
34 stars 13 forks source link

Question regarding "identifiers" in "dds.pf.tmLanguage.json" #141

Closed richardm90 closed 3 months ago

richardm90 commented 4 months ago

I was viewing the DDS source for a physical file the other day and noticed that the "R" in position 29 was not highlighted when the length of the field name is 10 characters long. image If I remove the whole "identifiers" section from the syntax file then it works as expected. image I couldn't see any specific documentation in the Language Configuration Guide that mentioned "identifiers" so was curious as to what this definition actually does. Does anyone know? As an aside the pattern name within the "identifiers" section is identifier.other.dds.lf.identifiers rather than identifier.other.dds.pf.identifiers.

barrettotte commented 4 months ago

Identifier is a term used during lexing/parsing for representing variables, parameters, user-defined functions, etc (https://en.wikipedia.org/wiki/Lexical_analysis); essentially any programmer named thing in the source code. This term is used in the vscode docs at https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#standard-token-types-and-modifiers.

I think there may be a regex bug in the R column example you provided; I will look into this. Additionally, I agree the pattern name is wrong and is a copy/paste error that needs correcting.

barrettotte commented 3 months ago

Fixed in v0.6.18 - https://github.com/barrettotte/vscode-ibmi-languages/releases/tag/v0.6.18

richardm90 commented 3 months ago

I can confirm this is working.

Is the identifiers section still required?