search

barribob / bosses-of-mass-destruction

https://www.curseforge.com/minecraft/mc-mods/bosses-of-mass-destruction-alpha
Other
16 stars 21 forks source link

net.minecraft.advancement.PlayerAdvancementTracker.updateDisplay running in infinite recursion due to error in BOMD advancements #96

Closed Nitjsefnie closed 1 year ago

Nitjsefnie commented 1 year ago

Not sure which of my mods managed to pull this out, but due to too many mods. https://crashy.net/f3eef7a0-2406-4964-8127-a03045cd8926 However, since this is the last mod I've installed, I decided to dig into your code to investigate your advancements https://github.com/miyo6032/bosses-of-mass-destruction/blob/09e3c7f947d8a4bbaf62f5d5986c0b447e698537/src/main/resources/data/bosses_of_mass_destruction/advancements/adventure/void_blossom_defeat.json#L21 After fixing this line in my clone, I haven't been receiving crashes anymore. Since I've got no idea how you manage your repo, instead of making a pull request, I'm providing you with the instructions on how to fix it. Enjoy.

barribob commented 1 year ago

Thanks - must be some conflict with a mod using the advancements