search

barronalex / Dynamic-Memory-Networks-in-TensorFlow

Dynamic Memory Network implementation in TensorFlow
MIT License
180 stars 80 forks source link

Where is dmm_orignal? #10

Closed hsm207 closed 6 years ago

hsm207 commented 6 years ago

In line 24 of the dmm_train.py module, we have:

if dmn_type == "original":
    from dmn_original import Config
    config = Config()
elif dmn_type == "plus":
    from dmn_plus import Config
    config = Config()
else:
    raise NotImplementedError(dmn_type + ' DMN type is not currently implemented')

but there is no file named dmm_original.py.

barronalex commented 6 years ago

I ended up removing it from the repo since it performs far worse than the DMN+. It implemented the architecture described in https://arxiv.org/abs/1506.07285.