barroncraft / minecraft-dota

Shoot some towers
Other
2 stars 3 forks source link

Villagers disappear on 1.5 #53

Closed Framartin closed 11 years ago

Framartin commented 11 years ago

With the 1.5 upgrade of Minecraft, villagers on the spawn disappear, so it's impossible to trade. And without a bow, we simply cannot play. The game is blocked.

Nullreff commented 11 years ago

I'll have a a break from work in around 1-2 hours. Will work on fixing it then.

Framartin commented 11 years ago

Whao, you're very quick ! Thanks a lot for all you did :) This is awesome !

Nullreff commented 11 years ago

I've reverted dota2.barroncraft.com and dota3.barroncraft.com back to 1.4. It looks like I'm going to have to rebuild the plugin as it has server version checks built in.

Nullreff commented 11 years ago

After removing the version check from Shopkeepers, it's still crashing. It's not going to work unless the unsafe portions are updated to use Minecraft 1.5. Until the plugin author (or myself) update it, dota.barroncraft.com has also been reverted to 1.4.7.

Framartin commented 11 years ago

Noted. Thanks. If I can contribute to anything for the map, do not hesitate to tell me (but i'm not a developer).

Note : The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

Nullreff commented 11 years ago

The first server (dota.barroncraft.com) seems to be bugged : doors of the red team are closed, but blue's ones are open.

/surrender will reset the server

Nullreff commented 11 years ago

Ok, I managed to get it to work by decompiling and patching v1.11 with the following:

diff --git a/com/nisovin/shopkeepers/ShopkeepersPlugin.java b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
index 6c2dbf5..86d2d19 100644
--- a/com/nisovin/shopkeepers/ShopkeepersPlugin.java
+++ b/com/nisovin/shopkeepers/ShopkeepersPlugin.java
@@ -64,18 +64,7 @@ public class ShopkeepersPlugin extends JavaPlugin {
         plugin = this;

         // load volatile code handler
-        String version = getServer().getVersion();
-        if (version.contains("(MC: 1.4.5)")) {
-            volatileCodeHandle = new VolatileCode_1_4_5();
-        } else if (version.contains("(MC: 1.4.6)")) {
-            volatileCodeHandle = new VolatileCode_1_4_6();
-        } else if (version.contains("(MC: 1.4.7)")) {
-            volatileCodeHandle = new VolatileCode_1_4_R1();
-        } else {
-            getLogger().severe("Incompatible server version: Shopkeepers plugin cannot be enabled.");
-            this.setEnabled(false);
-            return;
-        }
+        volatileCodeHandle = new VolatileCode_1_4_R1();

         // get config
         File file = new File(getDataFolder(), "config.yml");

It's downloadable here if anyone else is having this problem. I take no responsibility for what this may do to your server. The latest version of shopkeepers works with Minecraft 1.5. If you downloaded my patched plugin please update.

@Framartin If this comes back or the shopkeepers break again let me know.