search

barronh / pseudonetcdf

PseudoNetCDF like NetCDF except for many scientific format backends
GNU Lesser General Public License v3.0
76 stars 35 forks source link

psuedonetcdf does not import with matplotlib 3.1.1 installed #69

Closed shoyer closed 5 years ago

shoyer commented 5 years ago

Example traceback:

Traceback (most recent call last):
  File "xarray/util/print_versions.py", line 146, in <module>
    import PseudoNetCDF
  File "/usr/share/miniconda/envs/test_env/lib/python3.6/site-packages/PseudoNetCDF/__init__.py", line 39, in <module>
    from . import cmaqfiles
  File "/usr/share/miniconda/envs/test_env/lib/python3.6/site-packages/PseudoNetCDF/cmaqfiles/__init__.py", line 21, in <module>
    from .profile import *
  File "/usr/share/miniconda/envs/test_env/lib/python3.6/site-packages/PseudoNetCDF/cmaqfiles/profile.py", line 5, in <module>
    from matplotlib.mlab import csv2rec
ImportError: cannot import name 'csv2rec'

csv2rec was removed from matplotlib in https://github.com/matplotlib/matplotlib/pull/12165

Due to this import error, psuedonetcdf integration in xarray is currently not getting tested.

barronh commented 5 years ago

Thanks for the catch! I am working to put out a fix.

barronh commented 5 years ago

@shoyer - I've updated a #bugfix/csv2rec

For integration with xarray, do I need to update the conda recipe or make a new recipe?

Thanks,

shoyer commented 5 years ago

Once you're uploaded the release to pypi, conda-forge should automatically generate a pull request to update the conda recipe. You'll just have to merge it.

On Wed, Jul 10, 2019 at 5:24 AM barronh notifications@github.com wrote:

@shoyer https://github.com/shoyer - I've updated a #bugfix/csv2rec

For integration with xarray, do I need to update the conda recipe or make a new recipe?

Thanks,

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/barronh/pseudonetcdf/issues/69?email_source=notifications&email_token=AAJJFVWCAONRMPKPWRMYII3P6XIIDA5CNFSM4H6UMKOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZTJFBY#issuecomment-510038663, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVSSKPVLAVMDAUHDTYDP6XIIDANCNFSM4H6UMKOA .

barronh commented 5 years ago

@shoyer

I think we're all set. How can I confirm?

https://github.com/conda-forge/pseudonetcdf-feedstock/pull/3

shoyer commented 5 years ago

Let's see the PNC tests get run with https://github.com/pydata/xarray/pull/3143

shoyer commented 5 years ago

Yes, it's working now!