search

barrowclift / shelf

Beautifully display your record collection on the Internet
https://shelf.barrowclift.me
MIT License
15 stars 2 forks source link

Node.js Port / IP Address #1

Closed mrtimothyduong closed 6 years ago

mrtimothyduong commented 6 years ago

Hi Barrowclift,

I'm having issues with the nginx server blocks and not 100% sure what to input for the ipaddress:proxyport for the 'proxy_pass'

Is there a specific Port for the node.js application?

Everything else is working in terms of the node.js apps based on the logs, just not able to publish it.

Regards,

Timothy

barrowclift commented 6 years ago

I apologize, Timothy, the code block in the documentation was simply incorrect. I collect documentation as I go, and it looks like I had forgotten to going back and correct that snippet with a working version. Thanks so much for bringing this to my attention, it's now been updated to be correct.

To answer your question: The proxy_pass value should be http://localhost:10800;, the value in the original example didn't make any sense and was also pointing to the wrong port entirely (8080, instead of Shelf's default of 10800).

Just in case you changed the port defined in server.js@DEFAULT_SERVER_SETTINGS.port, then you'll unfortunately need to merge in f963f or change it back to the default value of 10800. While correcting the documentation, I noticed there was unfortunately a static usage of the default value still left in the codebase, which has now been updated to correctly use the config value.

mrtimothyduong commented 6 years ago

Hi @barrowclift

Thanks for that, was scouring the server.js and saw port 10800 but still was not able to get it working.

Will rebuild and report accordingly :)