search

barryWhiteHat / baby_jubjub_ecc

altbn128 twisted ewards curve point addion, point multiplicaion, eddsa signature verificaion and pedersen commiments
GNU General Public License v3.0
65 stars 14 forks source link

Ed25519 private key sk is not defined #10

Closed mathcrypto closed 5 years ago

mathcrypto commented 5 years ago

In the ed25519 test example, the private string sk is used to generate the public key (see https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py#L172 )and also the signature but its value was not defined.

barryWhiteHat commented 5 years ago

I think sk is defined https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/test_eddsa.py#L47

Is this what you mean?

Also my general disclaimer. This is POC code. Check out https://github.com/harryR/ethsnarks or https://github.com/iden3/circomlib/blob/master/circuits/eddsa.circom For production implementations. That have been reviewed and optimized more.

mathcrypto commented 5 years ago

Thank you, I meant it was not defined here https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py

barryWhiteHat commented 5 years ago

I am not sure which instance you are talking about

Both signature(m,sk,pk) and def publickey(sk) pass sk as parameter when the function is called.

Do you get an error? Sorry I am probably missing something.

mathcrypto commented 5 years ago

Ah I tried to run https://github.com/barryWhiteHat/baby_jubjub_ecc/blob/master/tests/ed25519.py test alone that's why it did not work, but when I run all tests together it works fine. Thanks

barryWhiteHat commented 5 years ago

No problem. Happy to help.

I would recommend building with one of the more maintinted languges.

If you have more questions feel free to reach out here or on gitter. Also I would be intersted to hear what you are working on.

feel free to close this issue if its resolved.