barryanders / grav-plugin-blackhole

The static site generator for Grav CMS
Other
169 stars 18 forks source link

Fix undefined variable making --output-url option ignored #19

Closed crittermike closed 7 years ago

crittermike commented 7 years ago

I'm not sure if it's a PHP version mismatch or something, but on my end, the $output_url inside the setCallback() was empty, so it wasn't ever doing the portal() find/replace. Here's an attempt at fixing that. Not sure if there's a cleaner way though.

ghost commented 7 years ago

You're right, it's not working. I think I broke it when I implemented rolling curl. Thanks for the fix, it looks good so I'm going to test it out.

ghost commented 7 years ago

It works on my end. Thanks again!