barryhennessy / google-api-php-client

Automatically exported from code.google.com/p/google-api-php-client
Apache License 2.0
0 stars 0 forks source link

revokeToken() does not return boolean in apiClient.php #104

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. instantiate an api client
2. generate a valid access token
3. call $client->revokeToken() capturing the return value
4. var_dump() the return value

What is the expected output? What do you see instead?
$status = $client->revokeToken();
var_dump($status);

Expected results: true or false
Actual results: null

What version of the product are you using? On what operating system?
v0.5.0 on RHEL 4.9 using PHP 5.3.10

Please provide any additional information below.
This is a simple fix; just need to add a return statement.

Original issue reported on code.google.com by The.Capt...@gmail.com on 20 Mar 2012 at 11:58

Attachments:

GoogleCodeExporter commented 8 years ago
Thank you for this patch! Looks good to me.

We will need you to first fill out a contributor license agreements (it is very 
simple).
http://code.google.com/legal/individual-cla-v1.0.html

Original comment by chirags@google.com on 21 Mar 2012 at 6:44

GoogleCodeExporter commented 8 years ago

Original comment by ianbar...@google.com on 22 Mar 2013 at 1:58

GoogleCodeExporter commented 8 years ago
This issue tracker is now closing. Development on the Google PHP client library 
moved to GitHub with the release of the 1.0.0-alpha, and now the 1.0 branch has 
reached beta status there will be no further releases of the 0.6 branch of the 
library. 

Please take a look at the latest version on 
https://github.com/google/google-api-php-client

For information on migrating, please take a look at this guide: 
https://developers.google.com/api-client-library/php/guide/migration

For general library support please ask a question on StackOverflow: 
http://stackoverflow.com/questions/tagged/google-api-php-client

If you are looking for support with a specific API, please contact the team 
working with that API via StackOverflow or their preferred support mechanism. 

If your issue still exists with the new version of the library, please raise a 
bug in the GitHub issue tracker with a minimal code sample. 

Thanks!

Original comment by ianbar...@google.com on 22 Jan 2014 at 4:53