search

barrykn / android-cm7-bkndh1

CyanogenMod personal dirty(?) hacks repo. Actually CM10.x as well as CM7, despite the name
1 stars 0 forks source link

1500ms long press delay is too short!! #8

Open barrykn opened 11 years ago

barrykn commented 11 years ago

I just got to see this today. I don't know how long will be long enough. :(

barrykn commented 11 years ago

Memo to self: RESIST THE TEMPTATION TO SLAM A FIX FOR THIS INTO PRODUCTION. THIS NEEDS TESTING FIRST.

barrykn commented 11 years ago

Quoting from barrykn/android_frameworks_base-cm72-bkndh1@0e201a5209cac1c7811340734430ce0b6cbae663:

"My gut feeling is that 1500ms won't be enough, but I think I'll give sanity a chance first."

Heh. I sure didn't expect it to take almost a year for my gut instinct to be validated, however.

barrykn commented 11 years ago

Oops, I wasn't expecting "should fix" to automatically close this issue -- I still need to fix it for CM10.1.

barrykn commented 11 years ago

I've coded a fix for CM10.1 but I have some more issues to file (and code fixes for) before I test.

barrykn commented 11 years ago

I've tested the fix for both CM7.2 and CM10.1, but I'll leave this issue open until I get the CM10.1 code posted to GitHub.

barrykn commented 11 years ago

By the way, 14.5 seconds is working fine in production on CM7.2. So far.

barrykn commented 11 years ago

For the record: By the time this change became necessary, my user was much closer to the end of her life than I [had] realized [at the time]. [Edited 20130813 -- attempted to clarify this comment.]

barrykn commented 11 years ago

In retrospect, perhaps 5 seconds would have been sufficient. However, I couldn't have been absolutely sure, and I didn't want to take any chances.

However, I do want to note that down in case I (or anyone) need(s) to revisit this issue at any point.