search

barrysteyn / pelican_plugin-render_math

A plugin for the pelican blog to allow it render mathematics in Latex.
67 stars 25 forks source link

Update math.py as MD_EXTENSIONS setting is now a dictionary. #29

Closed SimonStJG closed 6 years ago

SimonStJG commented 8 years ago

Hey Barry,

The format of the MD_EXTENSIONS setting in pelican recently changed to a dictionary. This commit updates your awesome plugin to cope with that.

Simon

barrysteyn commented 8 years ago

Thanks. I just need to test your addition. I will try that tonight (or early tomorrow) and if it works, I will submit it to the pelican creators.

Thanks again for doing this

barrysteyn commented 8 years ago

@SimonStJG The latest version of Pelican (version 3.6.3) seems to work fine for me without your changes. What version of Pelican are you using that has made these changes to the the MD_EXTENSTIONS setting.

SimonStJG commented 8 years ago

@barrysteyn I'm not sure exactly how Pelican's versioning works, but I was working off master. The commit which introduces the change is https://github.com/getpelican/pelican/commit/510961bbb9be62a687c773b226374084ecd011ba

barrysteyn commented 8 years ago

Okay, you are working on the cutting edge version then. Unfortunately, all things in the master repo are not finalized yet. So I think we should wait until the format changes officially before I apply your changes (which will come in very useful at that time) On Feb 16, 2016 10:24 AM, "Simon St John-Green" notifications@github.com wrote:

@barrysteyn https://github.com/barrysteyn I'm not sure exactly how Pelican's versioning works, but I was working off master. The commit which introduces the change is getpelican/pelican@510961b https://github.com/getpelican/pelican/commit/510961bbb9be62a687c773b226374084ecd011ba

— Reply to this email directly or view it on GitHub https://github.com/barrysteyn/pelican_plugin-render_math/pull/29#issuecomment-184812159 .