barrysteyn / pelican_plugin-render_math

A plugin for the pelican blog to allow it render mathematics in Latex.
67 stars 25 forks source link

MATH is undefined when generating html #5

Closed jkrshw closed 10 years ago

jkrshw commented 10 years ago

Hi, this error relates in particular to the pure pelican theme but I'm raising it here since you're the plugin maintainer and added the code.

If I don't have render_math available, when trying to generate my site with the latest pure theme I get the following error:

CRITICAL: 'MATH' is undefined

Which is caused by the following in index.html

{% if not MATH['auto_insert'] %}
  {% if page and page.mathjax or article and article.mathjax %}
    {% set mathjax = True %}
   {% endif %}
{% endif %}

I fixed this locally by either defining MATH = [] in pelicanconf.py or changing the if statement to check if MATH is defined. What would you suggest is the appropriate fix?

barrysteyn commented 10 years ago

Hi

The goal is to be as non-intrusive with respect to others as possible. Therefore it is my mistake doing this. I am using this theme as a model example of how the plugin works in a nice template.

I am going to fix this up now - look out for the pull request. Apologies this happened in the first place.

On 14 April 2014 02:23, jkrshw notifications@github.com wrote:

Hi, this error relates in particular to the purehttps://github.com/PurePelicanTheme/purepelican theme but I'm raising it here since you're the plugin maintainer and added the code.

If I don't have render_math available, when trying to generate my site with the latest pure theme I get the following error:

CRITICAL: 'MATH' is undefined

Which is caused by the following in index.htmlhttps://github.com/PurePelicanTheme/pure/blob/24bf7f10c22693fe8f578483900021db6c0ac6dd/templates/index.html

{% if not MATH['auto_insert'] %} {% if page and page.mathjax or article and article.mathjax %} {% set mathjax = True %} {% endif %}{% endif %}

I fixed this locally by either defining MATH = [] in pelicanconf.py or changing the if statement to check if MATH is defined. What would you suggest is the appropriate fix?

— Reply to this email directly or view it on GitHubhttps://github.com/barrysteyn/pelican_plugin-render_math/issues/5 .

barrysteyn commented 10 years ago

See fix here: https://github.com/PurePelicanTheme/pure/pull/7

jkrshw commented 10 years ago

Wow, thanks for the quick turn around.