Closed adridev closed 8 years ago
Is totally intentional, getMetadata() returns the metadata, false or exception and the exception is caught above. I don't know if empty array could be returned (a file without metadata) but in that case the result would be the same in the current code. let me review it.
I check all the common actions (update, duplicate, copy, paste, delete, create...) and all is woking well with S3 and local filesystems.
about the meta check, we can also add the empty meta case to return stat earlier. nothing will change at the moment but we will save the following checks over the meta array.
Just be aware that
false === $meta
is not the same as!$meta
, or is that change intentional? (!$meta
is also true for empty array)