barryvdh / elfinder-flysystem-driver

elFinder driver for Flysystem
183 stars 41 forks source link

update this package for laravel-elfinder #82

Closed siberfx closed 2 years ago

siberfx commented 2 years ago

I've tested all worked fine for me

jnoordsij commented 2 years ago

Hmmm this can't possibly working with the new Flysystem version. For example, the FilesystemInterface no longer exists in v3. Moreover the adapter property on Filesystem is no longer accessible (there is no longer a getAdapter method, see https://github.com/thephpleague/flysystem/blob/3.x/src/Filesystem.php), so the init function of the driver in this package will never work with the new version.

I'm afraid there's quite a lot of work to be done to get this going again with the new Flysystem version, probably near a full rewrite. Other problems are:

See also https://flysystem.thephpleague.com/docs/upgrade-from-1.x/

barryvdh commented 2 years ago

I've added a very minimal test suite in https://github.com/barryvdh/elfinder-flysystem-driver/commit/a83b178cdedf95fef5a7a4a40f6cea82c2538648 Let's see if I can get this to work with v3

barryvdh commented 2 years ago

I suspect it's basically this: https://github.com/barryvdh/elfinder-flysystem-driver/pull/83

Maybe you can give it a look? The Cache needs to be removed indeed, and some metadata is not as optimal now..

barryvdh commented 2 years ago

Fixed with the latest release.