barryvdh / laravel-debugbar

Debugbar for Laravel (Integrates PHP Debug Bar)
MIT License
17.05k stars 1.54k forks source link

debug bar showing 19-21mb memory usage on clean install laravel (welcome page) #1434

Closed Yogeshwar-Barai closed 1 year ago

Yogeshwar-Barai commented 1 year ago

I have tested it on laravel 8 , 9 and 10. all of them showing 19-21mb usage on welcome page while having fresh installation. Is this normal or something is wrong with package. I have php v8.1.17 installed. i did composer update as well. but issue remains same. I have watched few installation tutorials. They have less memory usage than mine for same laravel version.

Yogeshwar-Barai commented 1 year ago

image

Are you a mac user ?

Also What do you mean by that image?

Yogeshwar-Barai commented 1 year ago

https://laraveldaily.com/post/default-laravel-20-mb-ram-memory-usage-windows

I found a comment regarding this issue.

jaber-mtl commented 1 year ago

it's not an issue, it's normal.

erikn69 commented 1 year ago

@Yogeshwar-Barai hi, try https://github.com/maximebf/php-debugbar/pull/559, and if it works for you leave your review

Yogeshwar-Barai commented 12 months ago

@Yogeshwar-Barai hi, try maximebf/php-debugbar#559, and if it works for you leave your review

@barryvdh @erikn69

This fix doesn't seem to work.

PHP: 8.1.17 OS: windows 10

UPDATE 3: I checked with the Laravel 8, 9 and 10 as well but issue remains same. Following screenshot are the proof of my testing.

Laravel 8

 "barryvdh/laravel-debugbar",
  "version": "v3.7.0",
   "maximebf/debugbar": "^1.17.2",

image

UPDATE 1: Laravel 9

  "name": "barryvdh/laravel-debugbar",
  "version": "v3.9.2",
   "maximebf/debugbar": "^1.18.2",

image

UPDATE 2: Laravel 10 Latest

  "name": "barryvdh/laravel-debugbar",
  "version": "v3.9.2",
   "maximebf/debugbar": "^1.18.2",

image

erikn69 commented 12 months ago

@Yogeshwar-Barai hi, There was a change, it is no longer automatic, look at https://github.com/barryvdh/laravel-debugbar/pull/1467, must be enabled by $debugbar['memory']->resetMemoryBaseline();, If you don't enable it, it maintains the previous functionality.

"maximebf/debugbar": "^1.17.2" "maximebf/debugbar": "^1.18.2",

???, you have to upgrade to maximebf/php-debugbar/releases/v1.19.0

composer update

Also Laravel 8 is no longer supported, i manually copied barryvdh/laravel-debugbar, maximebf/debugbar to vendor, and it works too, no errors

Yogeshwar-Barai commented 11 months ago

@Yogeshwar-Barai hi, There was a change, it is no longer automatic, look at #1467, must be enabled by $debugbar['memory']->resetMemoryBaseline();, If you don't enable it, it maintains the previous functionality.

"maximebf/debugbar": "^1.17.2" "maximebf/debugbar": "^1.18.2",

???, you have to upgrade to maximebf/php-debugbar/releases/v1.19.0

composer update

Also Laravel 8 is no longer supported, i manually copied barryvdh/laravel-debugbar, maximebf/debugbar to vendor, and it works too, no errors

I didn't tried using that specific version. I was installing using default command and even after composer update it was not upgrading it to v1.19 coz previously stable version was 1.18.2. I will try and let you know.

Also your patch is yet to be merged. will it work without that patch?

UPDATE: I implemented your patch manually and it works like charm though I had to manually make it true or there is a command line which will be easier for users to use it rather than manual method.

Please let Barry know that he can merge this patch. @barryvdh @erikn69

image

erikn69 commented 11 months ago

Also your patch is yet to be merged

We have to wait for he to have a little time, and hopefully it will be merged into the package.

I had to manually make it true or there is a command line which will be easier for users to use it rather than manual method

With my patch, on config/debugbar.php

'options' => [
    'memory' => [
        'with_baseline' => true,  // Set boot memory usage as memory peak baseline
    ],
    ///

Or on a service provider

public function register()
{
    $debugbar = $this->app->make(\Barryvdh\Debugbar\LaravelDebugbar::class);
    if ($debugbar->shouldCollect('memory', true)) {
        $debugbar['memory']->resetMemoryBaseline();
    }
}

composer update it was not upgrading it to v1.19

strange, I did composer update and it updated without problems