search

barryvdh / laravel-debugbar

Debugbar for Laravel (Integrates PHP Debug Bar)
MIT License
16.57k stars 1.53k forks source link

Remove deprecated TwigCollector #1580

Closed erikn69 closed 3 months ago

erikn69 commented 3 months ago

TwigCollector is deprecated maximebf/php-debugbar/src/DebugBar/Bridge/Twig/TwigCollector.php#L30

barryvdh commented 3 months ago

Hmm tests seem not to happy about this.

erikn69 commented 3 months ago

Works on a real app, but for tests, that path not exists

base_path has

But on test

Maybe using ReflectionClass, I'm going to try it

barryvdh commented 3 months ago

Do we need the path? In the other collectors that isn't used?

erikn69 commented 3 months ago

Do we need the path? In the other collectors that isn't used?

You are right, not needed, At first it gave me a problem, but maybe it was the browser