search

barryvdh / laravel-dompdf

A DOMPDF Wrapper for Laravel
MIT License
6.57k stars 965 forks source link

Laravel 11 Support #1036

Closed erikn69 closed 4 months ago

erikn69 commented 4 months ago

Closes #1034

Ref: https://github.com/laravel/framework/pull/50260 PhpStan fails on Laravel 10.x, I could add a baseline rule

Error: Cannot call method make() on Illuminate\Contracts\Foundation\Application|null.
 ------ --------------------------------------------------- 
  Line   src/Facade/Pdf.php                                 
 ------ --------------------------------------------------- 
  53     Cannot call method make() on                       
         Illuminate\Contracts\Foundation\Application|null.  
 ------ ---------------------------------------------------
erikn69 commented 4 months ago

Laravel 10.x, 11.x

based on https://github.com/laravel/framework/pull/50260 static::$app could be null laravel/framework/src/Illuminate/Support/Facades/Facade.php#L327-L336

And __callStatic could throw RuntimeException laravel/framework/src/Illuminate/Support/Facades/Facade.php#L345-L347

Also resolveFacadeInstance always validate it with if (static::$app) { laravel/framework/src/Illuminate/Support/Facades/Facade.php#L229-L235