barryvdh / laravel-elfinder

elFinder bundle for Laravel
738 stars 169 forks source link

add support for Laravel 8 #285

Closed tabacitu closed 3 years ago

tabacitu commented 3 years ago

Good news @barryvdh ! it looks like all we need to do, to provide Laravel 8 support, is to allow the installation 🥳 I have tested the most important features, and they work just fine:

2020-09-08 10 07 20


If anybody else wants to test this, or upgrade to Laravel 8 before this PR gets merged (or an alternative one), please:

Note that I have no intention of keeping that fork. Immediately after the official repo provides Laravel 8 support, I'll delete it. At that point you should undo the changes above, run composer update and it'll work just fine.

nguyentranchung commented 3 years ago

php version should >= 7.3

tabacitu commented 3 years ago

Indeed, Laravel 8 does require PHP 7.3+, a requirement which should be imposed just fine thanks to the fact that illuminate/support is a dependency and has it - https://github.com/illuminate/support/blob/master/composer.json

This PR intentionally does not force a PHP version bump, it adds L8 support as a non-breaking change.

If someone installs this package on

No need to bump the required PHP version here too, in my opinion.

barryvdh commented 3 years ago

Thanks!