barryvdh / laravel-elfinder

elFinder bundle for Laravel
738 stars 169 forks source link

Refactor Laravel-specific code #320

Open jnoordsij opened 1 year ago

jnoordsij commented 1 year ago

This PR aimed to add support for Laravel 10, which was later introduced in #321.

It's remaining parts is refactoring some things to allow for easier static code analysis within IDE, to allow spotting deprecations and/or removals from Laravel more easily. It also specifically lists all used Illuminate dependencies in composer.json.

ToDo:

barryvdh commented 1 year ago

Thanks, did you get a chance to test this? Are the changes required or can we bump the versions for now?

barryvdh commented 1 year ago

I've tagged a versions which allows Laravel 10, but will consider this as an improvement.

jnoordsij commented 1 year ago

@barryvdh thanks for looking into this! I wasn't able to test this in my application yet, but a quick test round in a fresh Laravel skeleton allowed me to publish everything and use basic operations without any problems. So I think the Laravel 10 support is good to go!

I've rebased my branch so you can still merge in the changes. You're correct none of them are actually required for Laravel 10, they basically were the easiest way for me to check basic compatibility in terms of classes/functions using just an IDE. Nonetheless I think they're very useful to keep this package up to date ;)

jnoordsij commented 1 year ago

Subtle reminder this is still open; if there is anything I can do here, let me know!