[3.x] Use official ReflectionDocBlock

barryvdh / laravel-ide-helper

IDE Helper for Laravel

MIT License

14.17k stars 1.16k forks source link

[3.x] Use official ReflectionDocBlock #1522

Closed barryvdh closed 7 months ago

barryvdh commented 7 months ago

Summary

Try to avoid using the fork of ReflectionDocBlock.

The official lib still doesn't support changing the docs but it does support creating a new one..

Type of change

[x] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

[ ] Existing tests have been adapted and/or new tests have been added
[ ] Add a CHANGELOG.md entry
[ ] Update the README.md
[ ] Code style has been fixed via composer fix-style

barryvdh commented 7 months ago

Hmm it seems to show the classes for itself as FQN which is not really ideal probably.

barryvdh commented 7 months ago

@mfn we can remove it for the Model collector at least, except there a few changes (see comments mostly). Not sure if we need to change those, but it would be nice if we could just use the upstream package.

But we would need to do the same for the other generator command still.

barryvdh commented 7 months ago

Yeah I think the upstream lib doesn't handle generics like we want to. And in general, it tries to 'fix' this for us, which we don't really need..

barryvdh commented 7 months ago

Hmm not really happy with this as-is. Might leave it to think about it, or explore alternatives (see #1511)

func0der commented 4 months ago

Stumbled upon this. Would it be possible if we would update the barrryvdh/ReflectionDocBlock to the newest version and re-apply the needed modifications?

Especially this is kinda needed: Serializer::removeTrailingSpaces() PHPCs is biting my butt for those trailing spaces xD