::find and ::first not returning correct model

[juliansteenbakker]

Versions:

• ide-helper Version: 3.2.2
• Laravel Version: 11.30.0
• PHP Version: 8.3.x

Description:

::find returns Illuminate\Database\Eloquent\Collection|null|TModel ::first returns Illuminate\Database\Eloquent\TValue|null

[mfn]

Probably because \Illuminate\Database\Eloquent\Builder::find transparently supports finding multiple models by their primary key

• L10 implementation: https://github.com/laravel/framework/blob/67d4d0dd8061227ef21a3ed7a0ad57c18d51861b/src/Illuminate/Database/Eloquent/Builder.php#L436-L450
• L11 has done it fancier, depending on whether an array is provided or not https://github.com/laravel/framework/blob/53193a218837f800ea1c9e2772dcdbe0fcd282cd/src/Illuminate/Database/Eloquent/Builder.php#L451

[pataar]

Actually, it's because generics aren't supported correctly. I tried to fix it on my fork, but it's a bit hard because of the forked phpdoc package that's included.

It should return a TModel, which is defined as template at the top of the Builder class:

Wat worked for me (it's far from ideal though), is replacing the @mixin \Eloquent for the @mixin Builder<$this> in each model phpdoc.

This gives the following result:

It can be done using this code snippet (requires the GNU sed version):

find app/Models -type f -name '*.php' -exec sed -i 's/@mixin Eloquent/@mixin \\Illuminate\\Database\\Eloquent\\Builder<\$this>/g' {} +
find app/Models -type f -name '*.php' -exec sed -i 's/@mixin \\Eloquent/@mixin \\Illuminate\\Database\\Eloquent\\Builder<\$this>/g' {} +