search

barryvdh / laravel-snappy

Laravel Snappy PDF
MIT License
2.63k stars 290 forks source link

Setting config value "timeout" to false causes the process timeout default value 60 secs #461

Closed alperyazgan-kfzteile24 closed 2 years ago

alperyazgan-kfzteile24 commented 2 years ago

Sorry for the wrong account usage

alperyazgan commented 2 years ago

Presumably setting the "timeout" to false should make the pdf creation process use no time limit (unlimited processing time).

But it does not; actually the Process is created with the default values;

...
$process = new Process($command, null, $this->env);

if (null !== $this->timeout) { <-- timeout is null so the following line is omitted
            $process->setTimeout($this->timeout);
        }
...

The construct for the Process class, as you can easily see timeout is 60 secs

public function __construct(array $command, string $cwd = null, array $env = null, $input = null, ?float $timeout = 60)

So, Unlimited time for the process could not be achieved.

Regards,

alperyazgan-kfzteile24 commented 2 years ago

Will open under another account