Django 2.2 support - Githubissues

barseghyanartur / django-fobi

Form generator/builder application for Django done right: customisable, modular, user- and developer- friendly.

https://pypi.python.org/pypi/django-fobi

484 stars 112 forks source link

Django 2.2 support #209

Closed barseghyanartur closed 5 years ago

freezed commented 5 years ago

I just started a new project based on Django 2.2. I can give feedback.

barseghyanartur commented 5 years ago

@freezed:

It would be great if you could. Ideally, in a form of a pull request. My preferred way of doing this is using django-nine and conditional imports, like here.

Two things to keep in mind:

Base your work on v0.13.x branch, since that's the stable one. The master contains yet untested class-based-views code.
I don't want to deprecate support for Django 1.8 yet.

freezed commented 5 years ago

Ok I am not familiar with django-nine tool and this will be my first attempt to test seriously an external package (and a huge one by the way). Let's try !

barseghyanartur commented 5 years ago

@freezed:

django-nine is just an easy tool for checking your Django version.

As of testing, you will need to add Django 2.2 to the tox. See the Testing section of the README.rst.

As I mentioned before, use v.013.x branch. Reading the wiki might be useful too.

barseghyanartur commented 5 years ago

@freezed:

Work towards 2.2 compat is WIP in branch wipe-lt-1-8.

barseghyanartur commented 5 years ago

Done in 0.14.