Closed adrien-delhorme closed 5 years ago
A lot of fobi configuration is based valid json.
If something goes wrong, you'll get errors in production.
It's configurable, thus everyone might do whatever is right for his case.
I'm sorry to insist, but I actually lost many user data because an UnicodeEncodeError
occurred in the db_store
handler (PR #222) and was hidden by the setting FOBI_FAIL_ON_ERRORS_IN_FORM_HANDLER_PLUGINS = False
. In production, no errors were thrown, and the users reach the success page without guessing their data were actually lost.
I understand it's configurable but I think the default should be to not hide errors.
To quote the Zen of Python: "Errors should never pass silently".
I see. Well, agreed then. Could you make a pr?
Yes! #223
Solved in 0.15.
What is the reason for hiding, by default, the exceptions that could occur in form handlers and form plugins? I don't think its a good idea to hide errors.
I think these default settings should be set to
True
: