search

barseghyanartur / django-fobi

Form generator/builder application for Django done right: customisable, modular, user- and developer- friendly.
https://pypi.python.org/pypi/django-fobi
484 stars 112 forks source link

django version check in theme templates not working #240

Closed 0pt1c closed 4 years ago

0pt1c commented 4 years ago

I'm updating a project to Django 3.0 and posted a comment last week regarding an issue with fobi and deprecated import statements in the theme templates.

https://github.com/barseghyanartur/django-fobi/pull/214#issuecomment-608072628

I updated to 0.16.2 to get the newest code, but am still getting the error. I think the version check is not working correctly. You can see in the first screenshot I'm on django 3.0, and the second screenshot shows that the version check didn't load the right import.

Screenshot from 2020-04-06 15-32-10

Screenshot from 2020-04-06 15-32-45

Additionally, this line in dashboard.html should probably be removed:

https://github.com/barseghyanartur/django-fobi/blob/1077c934cb0a0801ef6db6914f9ec4964da0c18d/src/fobi/contrib/themes/simple/templates/simple/dashboard.html#L6

barseghyanartur commented 4 years ago

Strange. I'll dig into it later today. Thanks for reporting.

barseghyanartur commented 4 years ago

@0pt1c:

Sorry for the buzz. Fixed in 0.16.4 by simple replace of the admin_static with static (since static is available in Django 1.11, which is the minimum supported version).

0pt1c commented 4 years ago

@barseghyanartur thanks so much for the change and getting the new version out so quickly!