search

barseghyanartur / django-fobi

Form generator/builder application for Django done right: customisable, modular, user- and developer- friendly.
https://pypi.python.org/pypi/django-fobi
485 stars 112 forks source link

Support Django 4.0 #265

Closed andrewsanchez closed 2 years ago

andrewsanchez commented 2 years ago

django-fobi currently supports up to Django version 3.1. Upgrading for Django 4.0 should be fairly straightforward, but it would be a breaking change. Would you welcome a PR implementing the necessary changes? If so, would you want to create a new release for Django 4.0-only support?

I got the test suite to pass on Django 4.0 with the changes here: https://github.com/healthvana/django-fobi/pull/1/files

barseghyanartur commented 2 years ago

My intention is to support all currently supported versions of Django (and even some unsupported ones, if they are semantically greater than the LTS). So, for instance, at least support 2.2 and also 3.0, 3.1, 3.2 and eventually - 4.0. I would welcome a PR supporting these. It shouldn't be very difficult, though. There aren't many breaking changes between Django 2.2 and 4.0 anyway. It should be pretty simple. OK, I just checked your changes. I don't see anything that would break on 2.2. Please, submit a PR and we'll see it from there.

andrewsanchez commented 2 years ago

Ok, great! I assumed it wasn't possible to support 2.2-4.0, but I guess I'm wrong! We'll see how the CI run goes. 😃