search

barseghyanartur / django-fobi

Form generator/builder application for Django done right: customisable, modular, user- and developer- friendly.
https://pypi.python.org/pypi/django-fobi
485 stars 112 forks source link

Django 4.1 support #278

Closed barseghyanartur closed 1 year ago

gabn88 commented 1 year ago

For all the apps I get this warning: RemovedInDjango41Warning: 'fobi.contrib.plugins.form_elements.content.content_image' defines default_app_config = 'fobi.contrib.plugins.form_elements.content.content_image.apps.Config'. Django now detects this configuration automatically. You can remove default_app_config.

This behaviour is since Django 3.2.

barseghyanartur commented 1 year ago

Work in-progress in the feature/add-django41-support branch.

barseghyanartur commented 1 year ago

All tests seem to pass. I'm going to test it more extensively tomorrow and if all goes well, release a new version tested with Python 3.10, 3.11 and Django 4.1.

barseghyanartur commented 1 year ago

Released in 0.19.6.

corentinbettiol commented 11 months ago

@barseghyanartur Hi, we still have deprecationwarnings on django-fobi for those lines:

$ poetry run python3 -Wa src/website/manage.py check
[...]
/home/me/proejct/.venv/lib/python3.10/site-packages/django/apps/registry.py:91: RemovedInDjango41Warning: 'fobi.contrib.plugins.form_elements.content.content_video' defines default_app_config = 'fobi.contrib.plugins.form_elements.content.content_video.apps.Config'. Django now detects this configuration automatically. You can remove default_app_config.
[...]

Are you gonna remove those default_app_config lines?

barseghyanartur commented 11 months ago

@corentinbettiol:

At some point. It doesn't stand in the way, so I'm not hesitant to remove it. Moreover, this library supports a wide range of Django versions, some of which are still dependent on the presence of the setting. Therefore, it's not on the road-map.