search

barseghyanartur / django-fobi

Form generator/builder application for Django done right: customisable, modular, user- and developer- friendly.
https://pypi.python.org/pypi/django-fobi
485 stars 112 forks source link

FIX: incorrect urls for files in emails #302

Closed corentinbettiol closed 1 year ago

corentinbettiol commented 1 year ago

PR made following this conversation in a previous PR.

The bug was triggered when using a full url in settings.MEDIA_URL instead of only a folder name.

The previous check would add base_url before our settings.MEDIA_URL if our url started with settings.MEDIA_URL, and now it adds it only if our url don't start with "http" (prevent adding "https://example.ext" before "https://media-example.ext").

barseghyanartur commented 1 year ago

@corentinbettiol:

Thank you! I'll make a minor release soon.

corentinbettiol commented 1 year ago

Thank you for your responsiveness!

barseghyanartur commented 1 year ago

Released in 0.19.7.