search

barseghyanartur / django-mongoengine-filter

django-filter for MongoEngine
https://pypi.org/project/django-mongoengine-filter/
13 stars 7 forks source link

AttributeError: 'BaseFilterSet' object has no attribute 'is_valid' #8

Closed jesusch closed 1 year ago

jesusch commented 4 years ago

see: https://github.com/carltongibson/django-filter/blob/master/django_filters/filterset.py#L208

Locally I fixed it by just adding

    def is_valid(self):
        return True
jesusch commented 4 years ago

which is not nice... I know

barseghyanartur commented 4 years ago

For the reference, work on this is done in sync-api branch.

I applied some changes to the code, yet untested though. Any help here is appreciated.

oussjarrousse commented 1 year ago

I think I can provide a pull-request for this shortly.

oussjarrousse commented 1 year ago

@barseghyanartur. I created a pull request that addresses this issue, and added a test for the new function is_valid() and also for FilterBoolean because the pipeline was not passing due to a decrease in coverage %. The newly added test improved coverage and the pipeline is passing (win + win)

barseghyanartur commented 1 year ago

Released in 0.4.2.