barsoom / attr_extras

Takes some boilerplate out of Ruby with methods like attr_initialize.
MIT License
560 stars 31 forks source link

Add support to default values for hash arguments #16

Closed victorarias closed 8 years ago

victorarias commented 9 years ago

Done:

henrik commented 9 years ago

Ping me when you feel done with this and I'll see if I can break it :)

victorarias commented 9 years ago

@henrik do it!

victorarias commented 9 years ago

Ok, all done :)

henrik commented 9 years ago

@victorarias Sorry it took so long. I finally reviewed this beast! :)

henrik commented 9 years ago

@victorarias Will you let me know when the review comments have been adressed, and I'll have another look and hopefully merge this bad boy?

victorarias commented 9 years ago

Sure, but I'm not super motivated to fix that at the moment :/

henrik commented 9 years ago

@victorarias No worries, I know the feeling :) Maybe we could pair on it some day or I could look at it myself if I feel motivated.

nitzanav commented 8 years ago

+1

henrik commented 8 years ago

Closing as incomplete for now. @victorarias, let's pair on this sometime and get it done :)

AlexVPopov commented 7 years ago

Such a pity this is unfinished... Having default values is one of the main reasons for me not to use this otherwise so handy gem :disappointed: