Optimize with class_eval?

barsoom / attr_extras

Takes some boilerplate out of Ruby with methods like attr_initialize.

MIT License

560 stars 31 forks source link

Optimize with class_eval? #24

Closed henrik closed 5 years ago

henrik commented 6 years ago

Like https://github.com/tonsser/takes_macro.

Consider:

We want good backtraces: https://stackoverflow.com/questions/2496102/what-does-class-eval-end-eval-file-line-mean-in-ruby See it used in Traco: https://github.com/barsoom/traco/blob/f0632591f26f762f73766999080a793dba98e6b4/lib/traco/attributes.rb#L24
Security implications. Any risk of end-user-provided data not being properly escaped, causing vulnerabilities?
Benchmark it (see takes_macro).

henrik commented 5 years ago

I'm going to close this since I have no immediate plans to look into it further. I think I experimented a bit at the time and ran into some issues. PRs welcome.