search

barsoom / attr_extras

Takes some boilerplate out of Ruby with methods like attr_initialize.
MIT License
560 stars 31 forks source link

Adding support for default values #26

Closed lesin closed 5 years ago

lesin commented 5 years ago

This PR adds support for default values for keyword arguments to attr_initialize as requested in #25.

The PR also contains changes to use new ruby syntax and to fix some warnings.

henrik commented 5 years ago

Hi @lesin, thank you so much! Hope to have a look in the next few days. Please ping me in a week or so if I haven't :)

lesin commented 5 years ago

Hi @henrik, I see Travis failed due to unsuccessful bundler installation. Don’t have permission to rerun it, may be it would help

henrik commented 5 years ago

@lesin I re-ran it and got errors like that again. I'll try re-running it a second time.

lesin commented 5 years ago

@henrik looks like there is a more general issue with .travis.yml file and bundler version should be specified explicitly for each ruby version we are checking. What do you think could be done?

lesin commented 5 years ago

ok, fixed :) waiting for review then

lesin commented 5 years ago

Hey @henrik would you have some time for a code review? :)

henrik commented 5 years ago

Hey! Working towards a pretty tight deadline at work for the coming weeks, so I'm finding it hard to take the time, but I'll try to carve some out! Sorry about that.

henrik commented 5 years ago

@lesin Sorry for taking so incredibly long – finally took the time. Beautifully done, thank you so much! This has been a much-requested feature :)

lesin commented 5 years ago

Great! This is a great project, so thank you for it :)