search

bart-kneepkens / SpellingCopBot

SpellingCop enforces custom spelling rules in Telegram chats
3 stars 1 forks source link

Handle tags and URLs more carefully #17

Closed MaikoKingma closed 6 years ago

MaikoKingma commented 6 years ago

When a tag is or contains a trigger this should be ignored.

bart-kneepkens commented 6 years ago

The bot should never trigger on a username tag or URL in a message. If the a rule's correction is a username tag or URL, it should not enclose the correction in backticks, since this makes it unclickable.

MaikoKingma commented 6 years ago

Note that this issue was initially created because Tags got corrected. Not that corrected tags are unclickable. Example: When there is a person with the tag @Bob and a rule 'Bob > 🅱o🅱`. In this case the bot will correct @Bob to @🅱o🅱 which defeats the purpose of using @Bob.

bart-kneepkens commented 6 years ago

@MaikoKingma indeed. Hence the The bot should never trigger on a username tag or URL in a message. 🙂

bart-kneepkens commented 6 years ago

Fixed in a4ad040.