search

bartavelle / language-puppet

A library to work with Puppet manifests, test them and eventually replace everything ruby.
BSD 3-Clause "New" or "Revised" License
51 stars 8 forks source link

Package Native Type is not applied #102

Closed PierreR closed 9 years ago

PierreR commented 9 years ago

Because package is in the list of defaultTypes, the validation nativePackage does not seem to have any effect.

For instance this works without error:

package {
    'stash':
      ensure => $version,
      coco => 'toto',
  }

Another issue is the fact that the validation for ensure on the package nativetype is too strict. According to https://docs.puppetlabs.com/references/latest/type.html#package-attribute-ensure, a version string might be used.

PierreR commented 9 years ago

Could you review these changes ? Thx

bartavelle commented 9 years ago

Looks good to me !