search

bartavelle / language-puppet

A library to work with Puppet manifests, test them and eventually replace everything ruby.
BSD 3-Clause "New" or "Revised" License
51 stars 8 forks source link

Drop Puppet 3 support #240

Closed PierreR closed 6 years ago

PierreR commented 6 years ago

With the latest versions of the concat submodule, the ensure attribute is forbidden on the fragment resource:

https://github.com/puppetlabs/puppetlabs-concat/blob/master/lib/puppet/type/concat_fragment.rb

To support this we need to remove this line: https://github.com/bartavelle/language-puppet/blob/master/src/Puppet/Language/NativeTypes/Concat.hs#L40

This change would completely break a puppet 3 compatible version that requires an older version of the concat module.

Maybe it is time to create a release 1.4.x that would stop supporting puppet version < 4 ?

What do you think ?

bartavelle commented 6 years ago

Sounds good to me. However it will probably require a bit more work before release.

Le 2 mars 2018 11:12 AM, "Pi3r" notifications@github.com a écrit :

With the latest versions of the concat submodule, the ensure attribute is forbidden on the fragment resource:

https://github.com/puppetlabs/puppetlabs-concat/blob/master/ lib/puppet/type/concat_fragment.rb

To support this we need to remove this line: https://github.com/bartavelle/language-puppet/blob/master/ src/Puppet/Language/NativeTypes/Concat.hs#L40

This change would completely break a puppet 3 compatible version that requires an older version of the concat module.

Maybe it is time to create a release 1.4.x that would stop supporting puppet version < 4 ?

What do you think ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bartavelle/language-puppet/issues/240, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIQ73rhxx4CRZ4L5-b8B1Cfu5fEjTjtks5taRsbgaJpZM4SZrMG .