bartavelle / language-puppet

A library to work with Puppet manifests, test them and eventually replace everything ruby.
BSD 3-Clause "New" or "Revised" License
51 stars 8 forks source link

Use ExceptT inplace of ErrorT. #96

Closed PierreR closed 9 years ago

PierreR commented 9 years ago

Thanks for reviewing these changes.

I think it is alright. I had to add the Monoid instance because with ExceptT that's the new constraint (instead of Error).

There might be a way to abstract checkAllSources with a generic function but I found it more flexible to handle it explicitly.

The reason for the PR is the dependency changes (from transformer-3.x to transformers-compat).