search

bartbutenaers / node-red-contrib-blockly

A Node Red node for visual programming a function using Blockly
Apache License 2.0
91 stars 22 forks source link

Problem using remove #38

Closed cymplecy closed 6 years ago

cymplecy commented 6 years ago

if you enter this image

press done double-click to re-edit and it is either gone or very mixed up

cymplecy commented 6 years ago

I don't know if the bug is to do with the block changing its shape but I'm now think that remove should be made part of the set block so that it doesn't have to change shape. I think changing shape might be technically allowed but maybe we should not do so

bartbutenaers commented 6 years ago

Simon (@cymplecy),

This is an annoying problem, since I had digg into Blockly's internals. I 'hope' it is solved now in the 1.1.0 branch. Have done some tests, and here it seems to be working fine now ...

P.S. I had added the 'remove' option in the get-block (instead of in the set-block), since the Blockly team did it the same way in their get-list-block (and not in their set-list-block): blockly_list_remove

If I would have added it to the set-block, the set-block shape would also have to be changed (since the 'value' input needed to be removed when the 'remove' option would be selected)...

Could you please test this ? Bart

cymplecy commented 6 years ago

Does it work for you? It still doesn't work for me