search

bartbutenaers / node-red-contrib-blockly

A Node Red node for visual programming a function using Blockly
Apache License 2.0
90 stars 22 forks source link

Byte block doesn't behave in the manner I think it should #62

Closed cymplecy closed 3 years ago

cymplecy commented 3 years ago

Since we are restarting :)

Back in the mists of time, I raised the point that I didn't think the way byte blocks are interpreted was correct.

We had lots of "discussion" and I never manged to convince you - maybe I did but who can remember after so long :) but this is BIG issue for me so I'm re-raising it again :)

In summary, I believe a byte block should return a single byte (or char) e.g byte(10) should give a single buffer with a value of 10 (e.g. a newline char) not the decimal number 10 as it does at the moment

This should not produce 10 image

it should give

image

cymplecy commented 3 years ago

It's all OK - after restarting and clearing cache and spinning around 10 times your nice tidy code behaves the same as my old rough code :)

We have a go to launch :)

bartbutenaers commented 3 years ago

Thanks!!!!! The function still contains your logic and code... Then I think you can finally close this Github issue? Thought this would never happen... For me beta.2 can be published after the issue is closed. I am not going to add new features anymore. We only need the french and russian translations.

bartbutenaers commented 3 years ago

@cymplecy : I have created release notes for beta 2...

cymplecy commented 3 years ago

Looks good

cymplecy commented 3 years ago

I'm officially closing the issue :-)