search

bartbutenaers / node-red-contrib-blockly

A Node Red node for visual programming a function using Blockly
Apache License 2.0
88 stars 22 forks source link

Resizing workspace fails #79

Closed bartbutenaers closed 3 years ago

bartbutenaers commented 3 years ago

@jsccjj ,

During my major changes, it seems I have introduced somewhere a bug. Because the resizing doesn't work anymore correctly:

image

You have already been busy with the resizing in the past, so would be nice if you could have a look at this.
If you don't have time I will have a look at it in a couple of days. No problem! Thanks!!

cymplecy commented 3 years ago

I just re-installed NR 1.3.5 and release-1.1.0 2 hours ago and resizing is working fine for me (the + - and funny X blocks I mean)

bartbutenaers commented 3 years ago

@cymplecy , Nice to have you back! Hope you had a nice holiday...

Btw I get that issue when I resize the config screen It doesn't fit into the window...

jsccjj commented 3 years ago

@bartbutenaers I would suspect the "oneresize" part didn't get triggered when you close the config node. I am setting up a VM to test. Will report back soon

jsccjj commented 3 years ago

@bartbutenaers

I could reproduce the issue and found the possible cause. It might be a minor typo. Please see the image below: image I changed Window.Blockly to window.Blockly on my own copy and it works for me now. Please let me know if it works for you.

bartbutenaers commented 3 years ago

Hi @jsccjj, That was indeed the root cause! I have pushed your fix to Github. Thanks a lot, much appreciated. I had no time this evening to work on the Blockly node... Bart