Closed echoix closed 3 years ago
When testing my changes, I caught a bug with the function nodes that included an <!-- -->
in the left only in French. After investigation, it was from the Blockly project, I filed an issue https://github.com/google/blockly/issues/5399, and it was fixed in the translation system, but the changes will only be reflected in the next release.
They suggested overriding the 7 strings, and it seems to work. We could add them until we can bump the Blockly dependency to the next release.
For French translation in #86
Morning @echoix,
Thanks for the translations and also thanks for immediately reporting the bug directly to the Blockly team! I have created a new issue, as a reminder for us to remove the patch lines at a next release. Because this repo is only one of my many repos, so it would be forgotten without doubt ;-)
Bart
Also thanks for the Crowdin proposal! Will keep that in mind, so perhaps I will contact you in the future about that... But normally we don't have this many translations. This blockly node has been kind of neglected the last 3 years due to lack of free time, so that is the reason why we need so many translations at the moment.
As discussed in this Node-RED forum post, I am suggesting an update to the French translations.
In this process, I encountered some little other problems with the original English file, such as unescaped special characters that want to be displayed as text (that aren't appearing correctly in English Node-RED either), and some typos/consistency problems. I think they deserve their own PR. There is also an unclosed parenthesis in
Blockly.Msg.TEXT_SPECIAL_CHARACTER_TOOLTIP = "A special character that shouldn't be escaped (by a '\\' prefix";
, that seems to be used as is in the UI, so they mightAlso, to help me with the process, I explored the use of a private copy of the repo in Crowdin (with a trial), a localization platform that I had already used as a volunteer (the same kind of product as Transifex or Weblate). It caught some inconsistencies like when the source was not capitalized at the beginning of the sentence, but was in French. If you think that you'd like to have a maintained localization for multiple languages, I could set up this project on Crowdin (available for open source projects without problems) that can really help to have a wider community contribute to localize, just let me know. With translation memory (from the project or Crowdin's Global TM) and machine translation, it really is easy, and synced back to the repo with a pull request. I even tried my best with the Russian translation, where I could do some obvious changes, use existing translations in the project to try to complete some new strings, and tried using various resources like Microsoft Terminology Search in its Language Portal (all translations Microsoft uses in its products) and Yandex's translation (with definitions)+Google Translate+Bing to cross validate. There are still some completely new strings that I didn't translate, as they don't bring more than a blind machine translation. Someone who understands needs to review.